Skip to content

refactor: remove all checks for debug mode - #53

Merged
carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:refactor/remove-debug-mode-checks
Apr 19, 2026
Merged

carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:refactor/remove-debug-mode-checks

Conversation

@carlos-granados

Copy link
Copy Markdown
Collaborator

Since we don't have any mode other than debug, we can remove all cases where we were checking if the mode was debug. The only other possible mode is off and all these places will not be called when the mode is off

@carlos-granados
carlos-granados force-pushed the refactor/remove-debug-mode-checks branch from 9d90492 to c7d54c0 Compare April 18, 2026 06:51
@pronskiy
pronskiy self-requested a review April 19, 2026 17:22

@pronskiy pronskiy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing so far?

@carlos-granados
carlos-granados force-pushed the refactor/remove-debug-mode-checks branch from c7d54c0 to b6e3568 Compare April 19, 2026 19:35
@carlos-granados
carlos-granados force-pushed the refactor/remove-debug-mode-checks branch from b6e3568 to 078859c Compare April 19, 2026 19:47
@pronskiy
pronskiy self-requested a review April 19, 2026 20:05
@carlos-granados
carlos-granados merged commit 54f71f3 into php-debugger:main Apr 19, 2026
14 checks passed
@carlos-granados
carlos-granados deleted the refactor/remove-debug-mode-checks branch April 19, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants