Set default start_with_request to yes and remove the "default" option - #34
Merged
carlos-granados merged 3 commits intoApr 14, 2026
Merged
Conversation
pronskiy
reviewed
Apr 2, 2026
| #endif | ||
|
|
||
| static const char *xdebug_start_with_request_types[5] = { "", "default", "yes", "no", "trigger" }; | ||
| static const char *xdebug_start_with_request_types[5] = { "", "yes", "no", "trigger" }; |
Comment on lines
483
to
492
| if (trigger_name) { | ||
| xdebug_log(XLOG_CHAN_CONFIG, XLOG_INFO, "Trigger value for 'XDEBUG_TRIGGER' not found, falling back to '%s'", trigger_name); | ||
| trigger_value = xdebug_lib_find_in_globals(trigger_name, &found_in_global); | ||
| } | ||
|
|
||
| /* Also try PHP_DEBUGGER_SESSION alias */ | ||
| if (!trigger_value && XDEBUG_MODE_IS(XDEBUG_MODE_STEP_DEBUG) && (for_mode == XDEBUG_MODE_STEP_DEBUG)) { | ||
| if (!trigger_value) { | ||
| trigger_name = "PHP_DEBUGGER_SESSION"; | ||
| trigger_value = xdebug_lib_find_in_globals(trigger_name, &found_in_global); | ||
| } |
Member
There was a problem hiding this comment.
These conditions can be simplified as I undersand, because trigger_name is always set, right?
Comment on lines
+538
to
+540
| /* Returns 1 if the mode is 'trigger', or 'default', where the default mode for | ||
| * a feature is to trigger. Does not check whether a trigger is present. */ | ||
| int xdebug_lib_start_if_mode_is_trigger(int for_mode) | ||
| int xdebug_lib_start_if_mode_is_trigger() |
carlos-granados
force-pushed
the
start_with_request_mode
branch
2 times, most recently
from
April 7, 2026 23:13
2f857a7 to
91627a0
Compare
pronskiy
requested changes
Apr 8, 2026
| } | ||
|
|
||
| int xdebug_lib_start_with_request(int for_mode) | ||
| int xdebug_lib_start_with_request() |
Member
There was a problem hiding this comment.
Suggested change
| int xdebug_lib_start_with_request() | |
| int xdebug_lib_start_with_request(void) |
let's keep it consistent with the rest of the codebase and the modern style
Does it also make sense to add these to config.m4?
-Wstrict-prototypes
-Wold-style-definition
-Wmissing-prototypes
Collaborator
Author
There was a problem hiding this comment.
Updated. I worked with the compiler warnings in another branch
| #define XDEBUG_START_WITH_REQUEST_TRIGGER 4 | ||
| #define XDEBUG_START_WITH_REQUEST_YES 1 | ||
| #define XDEBUG_START_WITH_REQUEST_NO 2 | ||
| #define XDEBUG_START_WITH_REQUEST_TRIGGER 3 |
Member
There was a problem hiding this comment.
Is it safe to change the values here?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is safe. These values are only used internally and not exposed to the user. In the xdebug_lib_set_start_with_request() function the actual value entered by the user, which will be a string will be transformed in one of these flags
carlos-granados
force-pushed
the
start_with_request_mode
branch
from
April 9, 2026 16:58
c6b4bf9 to
940159d
Compare
# Conflicts: # tests/debugger/bug02122.phpt # tests/debugger/start_with_request_default_break.phpt # tests/debugger/start_with_request_default_config.phpt
carlos-granados
force-pushed
the
start_with_request_mode
branch
from
April 13, 2026 17:20
940159d to
73e4488
Compare
Collaborator
Author
|
Rebased and ready to be merged |
pronskiy
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.