Skip to content

New commits to lnetatmo.py break existing functionality #62

Description

@baiti

I have a working python script that uses lnetatmo.py successfully to query two netatmo stations. Up until (eab2766) it worked flawlessly. The referenced commit was done for: #50 (comment).

Now with the current version: Update lnetatmo.py it is no longer working, it throws an exception during execution. There were more commits in between. I can't tell which commit really broke it. Here is the scenario (I am showing only the relevant code):

weatherData = lnetatmo.WeatherStationData(authorization)

for station in weatherData.stations:
    station_data = []
    module_data  = []
    station      = weatherData.stationById(station)
    pprint.pprint(station)
    station_name = station['station_name']

When I run this, I get:

None
Traceback (most recent call last):
  File "/home/baiti/newest_netatmo/./netatmo_influx.py", line 51, in <module>
    station_name = station['station_name']
                   ~~~~~~~^^^^^^^^^^^^^^^^
TypeError: 'NoneType' object is not subscriptable

I would conclude that weatherData.stationById(station) returns nothing. I would further conclude that the commits to this file after the one referenced above, are not just new functions, they break existing functionality.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions