Creating a working test environment for the Phaxio gem - #1
Conversation
|
Is there any good way to make the parameters in Ruby for the GET and POST to be optional like some are with the Phaxio API? I am not entirely sure how to handle this. If they are left to nil and sent as nil, I guess that is a solution? |
|
I think that last commit gets me to a point where I am ready to start working on some of the other functionality of the gem. Are there any tests or asserts that I should add? |
|
I was doing some thinking - should a gem like this have a logging functionality of the JSON responses or no? Not sure if that's something worth keeping track of or if that is out of the scope of the gem. |
|
I don't think so. The big thing is being able to send/receive your faxes. |
|
Okay, awesome. Then I will go ahead and disregard that idea! Does this code look good to merge? If so, I'll go head and start working on some of the other functionality in a new branch. |
|
Looks solid to me. |
Creating a working test environment for the Phaxio gem to help clearly move forward with other functionality
3 participants
I've created what I think to be the base structure for the gem.
Right now I am still wrapping my head around the process, but I think I've got the Client class laid out enough to actually start writing tests and figuring out the functionality.
Once I've got some tests running and the ability to create a fax works, we can merge this into master and then I will start working on the rest of the API functions for Phaxio.