Skip to content

V2.0.0 - #13

Merged
34 commits merged into
masterfrom
v2.0.0
Dec 4, 2017
Merged

34 commits merged into
masterfrom
v2.0.0

Conversation

@ghost

@ghost ghost commented Nov 8, 2017

Copy link
Copy Markdown

No description provided.

@ghost

ghost commented Nov 8, 2017

Copy link
Copy Markdown
Author

When merged, should be tagged and released as 2.0.0-beta.

@ghost ghost mentioned this pull request Nov 8, 2017
@ghost ghost closed this Nov 10, 2017
@ghost
ghost deleted the v2.0.0 branch November 10, 2017 16:10
@ghost
ghost restored the v2.0.0 branch November 10, 2017 16:11
@ghost ghost reopened this Nov 10, 2017

@jtnegrotto jtnegrotto left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I just have one question below.

Edit: Also, I'm not sure whether it needs to be part of this PR, but it looks like the new version needs documentation.

Comment thread lib/Phaxio.php Outdated
return $opResult;
}

private function curlRequest($method, $address, $params = array(), $async = false)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is $async ever true?

@ghost

ghost commented Nov 30, 2017

Copy link
Copy Markdown
Author

@jtnegrotto, I removed the obsolete async code. Docs will be addressed in a separate PR.

@ghost
ghost merged commit a29e215 into master Dec 4, 2017
@ghost
ghost deleted the v2.0.0 branch December 4, 2017 17:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant