fix: Use spikes_keep_in for regular spikes, too.#637
Merged
Conversation
eyal0
force-pushed
the
spikes_keep_in
branch
from
September 21, 2022 01:40
dd02391 to
094c320
Compare
Collaborator
eyal0
force-pushed
the
spikes_keep_in
branch
from
September 21, 2022 16:14
094c320 to
bda18ce
Compare
These spikes are not properly trimmed and though the math should not allow them, they can happen. When they do, they might jut into a neighboring trace and ruin the milling!
The spike math might lead a spike to point away from the trace instead of toward it. This is unlikely but when it happens, it might aim at a neighboring trace! And we don't yet have the neighboring trace's keep out so we can't use it. Rather than defer the computation of spikes, which would be difficult, we will just keep the spikes within the voronoi region of the trace. This only applies to regular traces, not to thermal reliefs nor voronoi milling. This fixes pcb2gcode#636
eyal0
force-pushed
the
spikes_keep_in
branch
from
September 22, 2022 04:52
bda18ce to
2453cbd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spike math might lead a spike to point away from the trace instead of toward it. This is unlikely but when it happens, it might aim at a neighboring trace! And we don't yet have the neighboring trace's keep out so we can't use it.
Rather than defer the computation of spikes, which would be difficult, we will just keep the spikes within the voronoi region of the trace.
This only applies to regular traces, not to thermal reliefs nor voronoi milling.
This fixes #636