Fix "Can't compare with units and without." exception#580
Closed
ndilieto wants to merge 3 commits into
Closed
Conversation
Enabling milldrill-diameter and min-milldrill-hole-diameter makes the program abort with the following exception: > Exporting milldrill... terminate called after throwing an instance of 'comparison_exception' > what(): Can't compare with units and without. This patch fixes it. Signed-off-by: Nicola Di Lieto <[email protected]>
Contributor
Author
|
Also added a fix for #582 |
The %s format sometimes produces invalid g-code as small numbers are converted to exponential form. In addition larger numbers are truncated. Therefore change the format to %.5f which, as an example, outputs > o1 call [0.00003] [13.26319] [-0.08000] instead of > o1 call [2.54e-05] [13.2632] [-0.08] Signed-off-by: Nicola Di Lieto <[email protected]>
Collaborator
Contributor
|
No file diffs between this and master anymore so I think that we're done. Thanks for your work, both finding the issues and fixing them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling milldrill-diameter and min-milldrill-hole-diameter
makes the program abort with the following exception:
This patch fixes it.
Signed-off-by: Nicola Di Lieto [email protected]