Updated to use latest javaparser and Microsoft.CodeAnalysis libraries#2
Merged
Conversation
Owner
|
This is awesome 😃 thank you! Minor nitpick: can you use 4 spaces instead of tabs? That caused a lot of lines to change that otherwise wouldn't need to, and it doesn't match the existing spacing. Sorry to be a pain! |
Contributor
Author
|
Sure, I can use spaces. Did you want me to change all of the files I modified and squash my commits? |
Owner
|
No need to squash but if you can "format document" on those files to convert to spaces that would be appreciated. Thanks!! |
Contributor
Author
|
Done! :) |
ChristopherHaws
force-pushed
the
master
branch
from
a1adbb0 to
b7ec527
Compare
Owner
|
Awesome, thanks! |
Owner
|
@ChristopherHaws now that JavaParser supports 1.8, any interest in adding a LambdaExpressionVisitor? 😄 |
Contributor
Author
|
For sure! Right now I am playing around with getting comments to be ported. After that, I could take a look. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the project to use javaparser 3.0.0
Also, I removed the deprecated Roslyn nuget packages and replaced them with the latest Microsoft.CodeAnalysis packages.