[fix] fix build failure from package vulnerability#149
Open
thando-ndlovu wants to merge 1 commit into
Open
Conversation
packageid:Tmds.DBus.Protocol Added Warning As Error: Package 'Tmds.DBus.Protocol' 0.21.2 has a known high severity vulnerability, GHSA-xrw6-gwf8-vvr9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package 'Tmds.DBus.Protocol' explicitly added as build fails from transient package usage. `Warning As Error: Package 'Tmds.DBus.Protocol' 0.21.2 has a known high severity vulnerability, GHSA-xrw6-gwf8-vvr9
File JavaToCSharpGui\ViewModels\MainWindowViewModel.cs
Line187 has been changed from
int subStartIndex = dir.FullName.Length;toint subStartIndex = dir.FullName.Length - 1;'startIndex cannot be larger than length of string. (Parameter 'startIndex')'thrown on line193,string jOutPath = $"{outDirFullName}{jPath[subStartIndex..]}";when sub directories are not present or .java files are directly under chosen directoryPrevious result takes
maindir/subdir_one/file_one.javaand createsmaindir/maindir_csharp_outputsubdir_one/file_one.java&maindir/maindir_csharp_output/subdir_one/file_one.javacurrent result takes
maindir/subdir_one/file_one.javaand cretes onlymaindir/maindir_csharp_output/subdir_one/file_one.java