Skip to content

Commit a2b7733

Browse files
committed
PF 6 migration: Tabs
1 parent 49db96f commit a2b7733

File tree

6 files changed

+116
-218
lines changed

6 files changed

+116
-218
lines changed

components/src/main/java/org/patternfly/component/ScrollButtons.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.patternfly.core.Aria;
2121
import org.patternfly.core.LanguageDirection;
2222
import org.patternfly.core.ObservableValue;
23-
2423
import elemental2.dom.HTMLElement;
2524
import elemental2.dom.Node;
2625
import elemental2.dom.NodeList;
@@ -33,6 +32,7 @@
3332
import static org.jboss.elemento.Elements.setVisible;
3433
import static org.jboss.elemento.EventType.bind;
3534
import static org.jboss.elemento.EventType.resize;
35+
import static org.jboss.elemento.EventType.scroll;
3636
import static org.patternfly.component.button.Button.button;
3737
import static org.patternfly.core.Aria.hidden;
3838
import static org.patternfly.core.Aria.label;
@@ -64,6 +64,7 @@ public class ScrollButtons {
6464
private final ObservableValue<Boolean> disableForwardScrollButton;
6565

6666
private double scrollTimeout;
67+
private HandlerRegistration scrollHandler;
6768
private HandlerRegistration resizeHandler;
6869
private HandlerRegistration transitionEndHandler;
6970

@@ -90,9 +91,12 @@ public ScrollButtons(HTMLElement component, HTMLElement itemsContainer, String c
9091
.aria(hidden, true)
9192
.aria(label, "Scroll forward"))
9293
.element();
94+
setVisible(scrollBackContainer, false);
95+
setVisible(scrollForwardContainer, false);
9396
}
9497

9598
public void attach() {
99+
scrollHandler = bind(itemsContainer, scroll, e -> updateScrollState());
96100
scrollBack.onClick((e, b) -> scrollBack());
97101
scrollForward.onClick((e, b) -> scrollForward());
98102
enableScrollButtons.subscribe((current, previous) -> {
@@ -125,6 +129,9 @@ public void attach() {
125129

126130
public void detach() {
127131
clearTimeout(scrollTimeout);
132+
if (scrollHandler != null) {
133+
scrollHandler.removeHandler();
134+
}
128135
if (resizeHandler != null) {
129136
resizeHandler.removeHandler();
130137
}

components/src/main/java/org/patternfly/component/navigation/Navigation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
import static org.jboss.elemento.Elements.nav;
5454
import static org.jboss.elemento.Elements.removeChildrenFrom;
5555
import static org.jboss.elemento.Elements.ul;
56+
import static org.jboss.elemento.EventType.scroll;
5657
import static org.patternfly.component.divider.Divider.divider;
5758
import static org.patternfly.component.divider.DividerType.li;
5859
import static org.patternfly.component.navigation.NavigationType.Horizontal.primary;
@@ -138,7 +139,6 @@ public static Navigation navigation(NavigationType type) {
138139
.attr(role, Roles.list)
139140
.element();
140141
scrollButtons = new ScrollButtons(element(), itemsContainer, component(nav, Classes.scroll, button));
141-
itemsContainer.addEventListener(EventType.scroll.name, e -> scrollButtons.updateScrollState());
142142
addAll(scrollButtons.scrollBackContainer, itemsContainer, scrollButtons.scrollForwardContainer);
143143

144144
} else if (type instanceof NavigationType.Vertical) {

0 commit comments

Comments
 (0)