feat(Spinner): Adding Spinner component - #99
danseethaler wants to merge 1 commit into
Conversation
94264ee to
fe04404
Compare
|
thanks @danseethaler . This looks pretty reasonable. can you deploy the storybook so @jgiardino can take a look? I need to update the PR template...notes are in the README on this... |
|
Quick glance thought... I think the new convention is to put the actual implementation inside I will double check this for anything else I can think of first thing tomorrow. Thanks for opening this up! |
fe04404 to
0ff98c1
Compare
0ff98c1 to
a0b7552
Compare
|
Well, looks like I used the storybook:deploy in a most unfortunate way. I wasn't certain which remote/branch to deploy to. Can you clarify this for me @priley86? I ran |
|
@danseethaler yes, you should use a different branch name. Apologies for any confusion. I will try to update the readme and the pull request template tomorrow. |
What: Adding Spinner component from main Patternfly library.
Why: To include more components in the react implementation.
How: Adding one component file and a stories file to demo.