react-core(fix): Use resizeObserver to trigger trimLeft calculation - #6529
Merged
Merged
Conversation
Collaborator
dlabrecq
force-pushed
the
4710-resize-observer-textinput
branch
4 times, most recently
from
October 29, 2021 18:00
d12b4ac to
0a6750e
Compare
dlabrecq
force-pushed
the
4710-resize-observer-textinput
branch
from
October 29, 2021 18:04
0a6750e to
fdf77f2
Compare
nicolethoen
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the TextInput has the isLeftTruncated prop set to true, other page elements push on the input and change the dimensions. In this scenario, the recalculation for trimming the text won’t always happen.
This fix uses the
ResizeObserverfrom #6528Fixes #4710
After
after.mov