-
Notifications
You must be signed in to change notification settings - Fork 392
feat(TextInput): add helper util for left trim #4691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
98d1b4e
feat(text): adds helper util for left trim
jenny-s51 24d1bfa
fix headings example
jenny-s51 0addd16
get by classname instead of id
jenny-s51 876fae6
add case for when there are no childNodes, WIP
jenny-s51 6113521
use ceil func and make input val a state var
jenny-s51 5ef58fc
input trim left
jschuler f385eac
fix innerRef uses
jschuler 7409c06
fix for FF
jschuler 7bebf07
cleanup
jschuler 930aae2
types
jschuler 26dc6c5
update snapshots and fix linting
jenny-s51 43af08a
update snapshots
jenny-s51 5888cdd
address PR feedback
jenny-s51 7728df0
extract isLeftTruncated
jenny-s51 be6cc58
add demo and integration test
jenny-s51 f18ad3c
update prop name
jenny-s51 b3a5316
update prop name
jenny-s51 a120a5d
Delete PageBreadcrumbAndTertiaryNavDemo.tsx
jenny-s51 62ed831
use prop directly on textInput component
jenny-s51 8776afa
PR feedback
jenny-s51 d406049
fix demo
jenny-s51 f02bfbb
add back ref
jenny-s51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i just realized that the input box dimensions can change even if there was no window resize, for example if a sidebar is opened. Perhaps we should look at something like the ResizeObserver instead
https://developer.mozilla.org/en-US/docs/Web/API/ResizeObserver
Example implementation
https://github.com/ZeeCoder/use-resize-observer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened followup issue for next milestone here #4710 @jenny-s51 @tlabaj