feat(Label): add no overflow prop - #4680
Merged
Merged
Conversation
Collaborator
|
PF4 preview: https://patternfly-react-pr-4680.surge.sh |
jenny-s51
previously approved these changes
Aug 19, 2020
jenny-s51
left a comment
jenny-s51
left a comment
Contributor
There was a problem hiding this comment.
These changes look good. isTruncated makes sense to me -- added a similar prop called isLeftTruncated in https://github.com/patternfly/patternfly-react/pull/4691/files.
jessiehuff
previously approved these changes
Aug 19, 2020
jessiehuff
left a comment
jessiehuff
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I agree that isTruncated makes sense to me.
tlabaj
reviewed
Aug 21, 2020
| <br /> | ||
| <br /> | ||
| <Label color="blue">Blue</Label> <Label color="blue" icon={<InfoCircleIcon />}> | ||
| <Label color="blue">Blue</Label>{' '} |
Contributor
There was a problem hiding this comment.
are these change because of the linter?
Contributor
Author
There was a problem hiding this comment.
These changes are because of Prettier
tlabaj
suggested changes
Aug 21, 2020
tlabaj
left a comment
tlabaj
left a comment
Contributor
There was a problem hiding this comment.
Can you please add new prop tp demo app and add test cse.
tlabaj
reviewed
Aug 21, 2020
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #4660
Looking for feedback on the prop name, is
isTruncatedclear or would something else likenoWrapornoOverflowbe better?