Conversation
…ts. (patternfly#299) react-bootstrap's Dropdown component passes, and tries to use, a ref passed to InfoTipMenu and InfoTipToggle. Since SFC's cannot have refs passed to them, I converted these two components back to class components. fix patternfly#297
* refactor(package): Migrate from npm to Yarn (patternfly#289) Use https://github.com/imsnif/synp to generate yarn.lock from package-lock.json. Fix node_modules paths. Update Travis config and project docs to use Yarn. Fix patternfly#215 * Address review comments * Update README * Update README on adding dependency via npm * Update npm references & improve Travis config
…tternfly#298) * fix(ListView): Fixed issue with hideCloseIcon not being respected * fix(ListView): Updated close icon to use knob in storybook Changed logic to use onclose instead of passing in hideCloseIcon to determine whether to show close icon * fix(ListView): Removed parameter hideCloseIcon
patternfly#301) debounce needs to be passed a function. fix patternfly#300
…atternfly#305) * refactor(components): Use ...props for destructing/spread'ing props Updated how destructuring and spreading assigments work by making the variable name consistent. fix patternfly#229 * fix(FilterActiveLabel): set p tag to accept props
…:fix script for human use (patternfly#308) Including --fix in the lint script run by CI means that any errors fixable by that will not fail CI, and will get checked in.
Add Slider component which uses the bootstrap-slider library, add storybook and tests. fix patternfly#183
…atternfly#306) Also adds checks for pinnable menus before applying pinned properties.
* Updating the contributing.md to include information about how to become a maintainer.
… commit (patternfly#309) Running eslint against files staged should prevent any lint failures with builds. Additionally running against fix will allow prettier and eslint to run at commit promoting consistent code.
…running yarn install automatical (patternfly#310) No more wondering why your code doesn't work and remembering you forgot to `yarn install`.
…izardPattern components (patternfly#268) BREAKING CHANGE: Wizard structure has changed
…fly#307) You can now pass persist={false} to VerticalNav to turn off the persistence behavior.
…tternfly#311) Added a skelton for the console package under `packages/console`. This package will include the upcoming VncConsole and SerialConsole.
The SerialConsole component wraps the Terminal component [1] to access serial console (PTY) of a server or a virtual machine. Part of the code (like styling) was already committed within #4a69ebd806.
…nfly#332) affects: @patternfly/react-codemods, @patternfly/react-console, patternfly-react, eslint-plugin-patternfly-react this change converts pf-react to use lerna/lerna-semantic-release and introduces monorepo folder structure
affects: @patternfly/[email protected] Released from sha 7e566df [skip ci] Tag for lerna release
affects: @patternfly/[email protected] Released from sha 7e566df [skip ci] Tag for lerna release
…o functions (patternfly#336) affects: patternfly-react
affects: [email protected] Released from sha f19e4f7 [skip ci] Tag for lerna release
…fly#341) After splitting the project to monorepo, styling of subpackages is handled independently and must be explicitely added to storybook. ISSUES CLOSED: patternfly#340
…on package (patternfly#335) affects: @patternfly/react-console, patternfly-react When moved to monorepo storybook contains multiple packages, reorder them so they corespond these packages.
affects: patternfly-react
affects: [email protected] Released from sha 27b206e [skip ci] Tag for lerna release
patternfly#344) * fix(console): remove files field. this pattern prevents other dist files from releasing. affects: @patternfly/react-console * update npmignore
affects: @patternfly/[email protected] Released from sha d55644c [skip ci] Tag for lerna release
…atternfly#350) affects: patternfly-react ISSUES CLOSED: patternfly#348
…atternfly#357) affects: patternfly-react
affects: [email protected] Released from sha 8cfdb1b [skip ci] Tag for lerna release
…rnfly#359) affects: @patternfly/react-console
… the SerialConsole component (patternfly#356) affects: @patternfly/react-console Default font family and size can be changed for the SerialConsole. Underlying xterm component uses html canvas to render text and seems not to support font style change via CSS.
affects: @patternfly/[email protected] Released from sha d6df56e [skip ci] Tag for lerna release
…mimic Patternfly.org (patternfly#342) affects: patternfly-react ISSUES CLOSED: patternfly#304
affects: patternfly-react ISSUES CLOSED: patternfly#366
…tternfly#370) affects: @patternfly/react-console
…es (patternfly#369) affects: @patternfly/react-console, patternfly-react
affects: @patternfly/[email protected] Released from sha 24b35bc [skip ci] Tag for lerna release
affects: [email protected] Released from sha 24b35bc [skip ci] Tag for lerna release
Ron-Lavi
force-pushed
the
feature/auto-complete
branch
4 times, most recently
from
May 31, 2018 08:44
aa84da1 to
5d4cfef
Compare
Ron-Lavi
force-pushed
the
feature/auto-complete
branch
from
May 31, 2018 08:46
5d4cfef to
cb1329c
Compare
Collaborator
Author
|
closing - merging to the wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook
re #190
re #281