fix(tables): update reactabular-table, fix provider renderers prop - #357
Merged
Merged
Conversation
affects: patternfly-react
Pull Request Test Coverage Report for Build 1367
💛 - Coveralls |
Member
|
bad if that is true, why did it break us? |
Member
Author
|
i think it is false 🤣. i filed an issue upstream: reactabular/reactabular#348 |
jeff-phillips-18
approved these changes
May 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
affects: patternfly-react
What:
The
reactabular-tabledependency recently caused a breaking change to ourTable.PfProvidercomponent. Thecomponentsprop has been changed torenderersand the backportedcomponentsprop no longer renders our tables at runtime. This was causing the deployed storybook tables to fail.The
componentsprop will be deprecated in future versions it seems.Link to Storybook:
https://rawgit.com/priley86/patternfly-react/reactabular-table-storybook/index.html
Additional issues:
Relates to #348