chore(vscode): remove eslint rule path options override - #346
Merged
Merged
Conversation
dmiller9911
approved these changes
May 14, 2018
dmiller9911
left a comment
dmiller9911
left a comment
Contributor
There was a problem hiding this comment.
Yes this should work. Sorry I missed this when looking things over for the monorepo.
jeff-phillips-18
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
the
eslint.optionsrule path override is no longer needed now that all eslint rules have been moved intoeslint-plugin-patternfly-react. Custom rules can be added into that package instead and we should get automatic eslint integration in the IDE. Prettier will also auto-fix our custom eslint rules ;)