feat(NotificationList) -Automates notification creation for list example - #329
Conversation
Pull Request Test Coverage Report for Build 1283
💛 - Coveralls |
|
Hey @AllenBW, I think the root cause of this behavior is our use of array indices as keys. In this branch, if you change this to key={notification.key}the bug goes away. I also doubled checked this in V2V by using Not sure if this will help with our quickly disappearing toasts, but I think this takes care of this issue :) Here are a couple links |
de93bbd to
10468de
Compare
|
@michaelkro Updated this example to mix a lil bit of original implementation with a more real world situation, and the bugfix yah mentioned! (storybook also updated) |
michaelkro
left a comment
There was a problem hiding this comment.
This improves the story to reflect a more likely use case, where notifications are dynamically added to the list. Looks good!
|
this feels like more of a |
10468de to
8b51339
Compare
|
@priley86 Reworded to chore! 😋 |
|
LGTM! |
serenamarie125
left a comment
There was a problem hiding this comment.
Oops - meant to approve not close 😊
Improves notification list example
here's the storybook of fun!