Conversation
Pull Request Test Coverage Report for Build 1273
💛 - Coveralls |
Contributor
|
Please see #329 (comment) |
Contributor
Author
|
Sounds good to me @michaelkro closing.. gonna update/keep the other one open, still might be nice to demonstrate a few different implementations of notification lists |
Contributor
|
Definitely! My guess is your new example will be much closer to a real use case, since notifications will most likely be dynamically added to and removed from We should def merge that one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #327
But wait wait wait.. your gonna wanta pop the changes here onto this branch to checkout the fix in action...
I'mma gonna attach a storybook of that above branch demonstrating FAILURE, because what you'll notice... is despite the each notification having
persistent=falsethe last one remainsIn other news, gonna throw up another pr using that same storybook example for notification list...