Skip to content

fix(VerticalNavigation): Accept no hover delay on subsequent hovers - #306

Merged
priley86 merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:vertical-nav
Apr 17, 2018
Merged

priley86 merged 1 commit into
patternfly:masterfrom
jeff-phillips-18:vertical-nav

Conversation

@jeff-phillips-18

Copy link
Copy Markdown
Member

Adds a fix to the Timer class to accept 0 as a delay without using the delay from the previous startTimer call.

Also adds checks for pinnable menus before applying pinned properties.

Also adds checks for pinnable menus before applying pinned properties.
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 1178

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 73.998%

Totals Coverage Status
Change from base Build 1164: 0.03%
Covered Lines: 1445
Relevant Lines: 1782

💛 - Coveralls

@mturley mturley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fixes.

@priley86
priley86 merged commit 6b10471 into patternfly:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants