refactor(components): Use ...props for destructing/spread'ing props - #305
Merged
Merged
Conversation
Updated how destructuring and spreading assigments work by making the variable name consistent. fix patternfly#229
Pull Request Test Coverage Report for Build 1182
💛 - Coveralls |
priley86
reviewed
Apr 13, 2018
| import PropTypes from 'prop-types'; | ||
|
|
||
| const FilterActiveLabel = ({ children, className, ...rest }) => { | ||
| const FilterActiveLabel = ({ children, className, ...props }) => { |
Member
There was a problem hiding this comment.
looks like this one can be removed or applied to the p tag... either should be fine.
Member
There was a problem hiding this comment.
i prefer to spread props on the p tag though ;)
chalettu
force-pushed
the
use-props-consistently
branch
from
April 16, 2018 16:21
f0417f7 to
6b82adb
Compare
jeff-phillips-18
approved these changes
Apr 16, 2018
Member
|
good to go... merging... |
priley86
approved these changes
Apr 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated how destructuring and spreading assigments work by making the variable name consistent. Updated code consistency documentation to reflect change
fix #229