fix(InfoTip): Fix ref errors from react-bootstrap for InfoTip components. - #299
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 1124
💛 - Coveralls |
dmiller9911
force-pushed
the
297-InfoTipFix
branch
from
April 9, 2018 14:36
8220708 to
245524a
Compare
react-bootstrap's Dropdown component passes, and tries to use, a ref passed to InfoTipMenu and InfoTipToggle. Since SFC's cannot have refs passed to them, I converted these two components back to class components. fix patternfly#297
dmiller9911
force-pushed
the
297-InfoTipFix
branch
from
April 9, 2018 15:15
245524a to
d5dabfa
Compare
dmiller9911
commented
Apr 9, 2018
| @@ -0,0 +1,71 @@ | |||
| import Timer from './Timer'; | |||
Contributor
Author
There was a problem hiding this comment.
these tests were added to meet coverage requirements.
priley86
approved these changes
Apr 9, 2018
jeff-phillips-18
approved these changes
Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
react-bootstrap's Dropdown component passes, and tries to use, a ref passed to InfoTipMenu and
InfoTipToggle. Since SFC's cannot have refs passed to them, I converted these two components back to class components.
Link to Storybook:
https://rawgit.com/dmiller9911/patternfly-react/info-tip-fix-storybook/index.html
Additional issues:
fix #297