Skip to content

fix(lint): fix lint error - #8452

Merged
jcmill merged 1 commit into
patternfly:mainfrom
kmcfaul:fix-main
Jun 12, 2026
Merged

fix(lint): fix lint error#8452
jcmill merged 1 commit into
patternfly:mainfrom
kmcfaul:fix-main

Conversation

@kmcfaul

@kmcfaul kmcfaul commented Jun 12, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Fix for lint error on main.

Summary by CodeRabbit

  • Style
    • Improved Avatar component styling organization through CSS property reordering.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: ffc419bb-b2df-42ed-b9f6-4bd9f8b5691c

📥 Commits

Reviewing files that changed from the base of the PR and between 90eb671 and 0b83df7.

📒 Files selected for processing (1)
  • src/patternfly/components/Avatar/avatar.scss

Walkthrough

The .pf-m-colorful Avatar styles reorder the vertical-align: middle; property to appear before the color property declaration, with no changes to values or selectors.

Changes

Avatar CSS Property Ordering

Layer / File(s) Summary
Avatar colorful property reordering
src/patternfly/components/Avatar/avatar.scss		 Within the .pf-m-colorful styles, vertical-align: middle; is repositioned before the color property for declaration consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title follows conventional commit format with type 'fix' and scope 'lint', but lacks specificity about the actual change being made. Consider revising the title to be more descriptive, such as 'fix(avatar): reorder vertical-align property in colorful variant' to better communicate the actual change.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8452.surge.sh

A11y report: https://pf-pr-8452-a11y.surge.sh

@jcmill
jcmill merged commit 9c07bb8 into patternfly:main Jun 12, 2026
6 checks passed
@patternfly-build

patternfly-build commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.6.0-prerelease.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jun 17, 2026
Merged
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcmill jcmill jcmill approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

3 participants

@kmcfaul @patternfly-build @jcmill