chore: validator updates to renovate.config by mcoker · Pull Request #8451 · patternfly/patternfly

mcoker · 2026-06-11T23:22:36Z

fixes #8449

Updates syntax per the renovate docs and running npx --package renovate renovate-config-validator

Summary by CodeRabbit

Chores
- Refined automated dependency update rules by switching to the recommended configuration.
- Disabled broad npm updates by default and added explicit allowlisting for PatternFly-related packages.
- Improved grouping for PatternFly dependencies and added more targeted handling for style-related packages.
- Included a dedicated rule for the PatternFly accessibility package to ensure consistent update behavior.

patternfly-build · 2026-06-11T23:26:42Z

Preview: https://pf-pr-8451.surge.sh

A11y report: https://pf-pr-8451-a11y.surge.sh

coderabbitai · 2026-06-11T23:26:43Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: e6aa6f53-1256-4fa0-a13c-e60d4e2f1b38

📥 Commits

Reviewing files that changed from the base of the PR and between 95feacd and 5a39b72.

📒 Files selected for processing (1)

.github/renovate.json

🚧 Files skipped from review as they are similar to previous changes (1)

.github/renovate.json

Walkthrough

Renovate config switches to config:recommended, replaces broad package-pattern disabling with an npm-wide enabled: false rule, and rewrites PatternFly package allowlist rules to use matchDatasources/matchPackageNames/matchPackagePatterns, including an explicit rule for @patternfly/patternfly-a11y.

Changes

Renovate Configuration Update

Layer / File(s)	Summary
Preset switch `.github/renovate.json`	`extends` updated from `config:base` to `config:recommended`.
Global npm disable `.github/renovate.json`	Replaced broad `packagePatterns: ["*"]` + excludes with a npm-wide disabling rule using `matchDatasources: ["npm"]` and `enabled: false`.
PatternFly allowlist rules `.github/renovate.json`	Grouped PatternFly rule rewritten to use `matchDatasources`/`matchPackageNames` and `matchPackagePatterns` (for `^stylelint`); explicit enabled rule added for `@patternfly/patternfly-a11y`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

patternfly/patternfly#8415: Also modifies .github/renovate.json packageRules to handle @patternfly/patternfly-a11y separately.
patternfly/patternfly#8410: Adjusts PatternFly-related dependency matching and allowlist/exclusion logic in .github/renovate.json.

Suggested labels

released on @prerelease``

Suggested reviewers

wise-king-sullyman

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title follows conventional commit guidelines with proper 'chore:' prefix and clearly describes the main change of updating Renovate configuration.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8449`: fixes the invalid matchPackageNames pattern mixing error, updates configuration syntax to comply with Renovate validator, and restores Renovate PR creation functionality.
Out of Scope Changes check	✅ Passed	All changes in the PR are directly related to fixing the Renovate configuration validation error specified in issue `#8449`, with no extraneous modifications.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (2)

.github/renovate.json (2)
7-13: 💤 Low value

Consider anchoring regex patterns for precision.

The regex patterns in matchPackagePatterns are not anchored, so they match as substrings. For example, @patternfly/react-core would technically match a package named foo-@patternfly/react-core-bar.

While npm package naming conventions make this unlikely in practice, anchoring the patterns would be more precise: ^@patternfly/react-core$.

However, this is a minor concern since the current patterns should work correctly for real-world package names.

Also applies to: 15-15
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/renovate.json around lines 7 - 13, Update the matchPackagePatterns
entries in .github/renovate.json to use anchored regexes so they match whole
package names (e.g., change "`@patternfly/react-core`" to
"^^`@patternfly/react-core`$$" — actually use ^ and $ around each pattern) ;
specifically edit the list items shown (e.g., "`@patternfly/patternfly-a11y`",
"`@patternfly/react-core`", "`@patternfly/react-icons`",
"`@patternfly/react-code-editor`", "`@patternfly/react-table`",
"`@patternfly/documentation-framework`", "sass") to wrap them with ^ and $ so they
become precise anchored patterns like ^`@patternfly/react-core`$ (apply same
change to the other matching line referenced).
14-14: Fix the mismatch claim for !stylelint* in .github/renovate.json (line 14). The earlier argument that stylelint* (as a regex) would not match stylelint-config-standard is wrong—stylelint* matches those strings via a substring match. If the goal is to exclude only names starting with stylelint, anchor the regex (e.g., ^stylelint) to avoid unintended substring matches.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/renovate.json at line 14, The exclusion "!stylelint*" currently
performs a substring match and unintentionally excludes packages like
"stylelint-config-standard"; update the pattern so it only matches names that
start with "stylelint" by anchoring the regex—replace "!stylelint*" with an
anchored pattern such as "!^stylelint" (or "!^stylelint.*" if you prefer
explicit matching of the rest) where the string "!stylelint*" appears.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/renovate.json:
- Around line 7-13: Update the matchPackagePatterns entries in
.github/renovate.json to use anchored regexes so they match whole package names
(e.g., change "`@patternfly/react-core`" to "^^`@patternfly/react-core`$$" —
actually use ^ and $ around each pattern) ; specifically edit the list items
shown (e.g., "`@patternfly/patternfly-a11y`", "`@patternfly/react-core`",
"`@patternfly/react-icons`", "`@patternfly/react-code-editor`",
"`@patternfly/react-table`", "`@patternfly/documentation-framework`", "sass") to
wrap them with ^ and $ so they become precise anchored patterns like
^`@patternfly/react-core`$ (apply same change to the other matching line
referenced).
- Line 14: The exclusion "!stylelint*" currently performs a substring match and
unintentionally excludes packages like "stylelint-config-standard"; update the
pattern so it only matches names that start with "stylelint" by anchoring the
regex—replace "!stylelint*" with an anchored pattern such as "!^stylelint" (or
"!^stylelint.*" if you prefer explicit matching of the rest) where the string
"!stylelint*" appears.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 3feda925-7482-4729-943e-abc2f8a4efb8

📥 Commits

Reviewing files that changed from the base of the PR and between 90eb671 and 7f87c2c.

📒 Files selected for processing (1)

.github/renovate.json

mcoker · 2026-06-12T16:05:03Z

@nicolethoen made some updates to simplify the file according to the renovate docs. Validates fine and claude approves. One other change I'd like to make is add ^@patternfly/react to matchPackagePatterns instead of listing the packages individually, like I did with the stylelint packages. I didn't because it wasn't that way before, where stylelint was (the previous config matched stylelint*). Any reason you can think of not to do that?

nicolethoen · 2026-06-12T18:33:35Z

Only reason to keep the explicit list would be if there's a @patternfly/react-* package in the repo you deliberately want to pin and not auto-update.
so yeah, go ahead and add ^@patternfly/react. I think it'll have the effect you want.

patternfly-build · 2026-06-18T17:31:11Z

🎉 This PR is included in version 6.6.0-prerelease.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

mcoker requested a review from nicolethoen June 11, 2026 23:24

coderabbitai Bot reviewed Jun 11, 2026

View reviewed changes

mcoker added 2 commits June 12, 2026 10:43

chore: validator updates to renovate.config

526ca29

chore: reformat

95feacd

mcoker force-pushed the update-renovate-config-6.11.26 branch from 7f87c2c to 95feacd Compare June 12, 2026 16:01

chore: update groupName, package pattern

5a39b72

nicolethoen approved these changes Jun 18, 2026

View reviewed changes

nicolethoen merged commit ca440fe into patternfly:main Jun 18, 2026
6 checks passed

patternfly-build added the released on @prerelease label Jun 18, 2026

This was referenced Jul 22, 2026

The automated release is failing 🚨 #8519

Closed

The automated release is failing 🚨 #8533

Closed

Navigation Menu

chore: validator updates to renovate.config - #8451

chore: validator updates to renovate.config#8451
nicolethoen merged 3 commits into
patternfly:mainfrom
mcoker:update-renovate-config-6.11.26

mcoker commented Jun 11, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

patternfly-build commented Jun 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

mcoker commented Jun 12, 2026

Uh oh!

nicolethoen commented Jun 12, 2026

Uh oh!

Uh oh!

patternfly-build commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mcoker commented Jun 11, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

patternfly-build commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

mcoker commented Jun 12, 2026

Uh oh!

nicolethoen commented Jun 12, 2026

Uh oh!

Uh oh!

patternfly-build commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mcoker commented Jun 11, 2026 •

edited by coderabbitai Bot

Loading

patternfly-build commented Jun 11, 2026 •

edited

Loading

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading