chore(ci): group non @patternfly/patternfly-a11y dependency bumps - #8415
wise-king-sullyman merged 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Renovate config adds ChangesDependency grouping configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/renovate.json (1)
23-41:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
@patternfly/patternfly-a11yis still included in the non-a11y group.Line 26 keeps
@patternfly/patternfly-a11yinside"groupName": "non-pf-a11y-deps", so the new dedicated rule won’t fully separate it from that group. Remove it from the non-a11y rule (or explicitly set a different group in the dedicated rule).Suggested fix
{ "groupName": "non-pf-a11y-deps", "datasources": ["npm"], "packageNames": [ - "`@patternfly/patternfly-a11y`", "`@patternfly/react-core`", "`@patternfly/react-icons`", "`@patternfly/react-code-editor`", "`@patternfly/react-table`", "`@patternfly/documentation-framework`", "sass", "stylelint*", "backstopjs" ] }, { + "groupName": "pf-a11y-deps", "datasources": ["npm"], "packageNames": [ "`@patternfly/patternfly-a11y`" ] }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/renovate.json around lines 23 - 41, The non-accessibility Renovate group "non-pf-a11y-deps" still lists "`@patternfly/patternfly-a11y`" in its packageNames array; remove "`@patternfly/patternfly-a11y`" from the packageNames list under the groupName "non-pf-a11y-deps" so it is not duplicated, or alternatively set a distinct groupName in the separate rule that targets "`@patternfly/patternfly-a11y`" to ensure the dedicated rule takes precedence.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.github/renovate.json:
- Around line 23-41: The non-accessibility Renovate group "non-pf-a11y-deps"
still lists "`@patternfly/patternfly-a11y`" in its packageNames array; remove
"`@patternfly/patternfly-a11y`" from the packageNames list under the groupName
"non-pf-a11y-deps" so it is not duplicated, or alternatively set a distinct
groupName in the separate rule that targets "`@patternfly/patternfly-a11y`" to
ensure the dedicated rule takes precedence.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 62ad53fb-b805-43ae-91bb-ccefca2b7f7d
📒 Files selected for processing (1)
.github/renovate.json
|
Preview: https://pf-pr-8415.surge.sh A11y report: https://pf-pr-8415-a11y.surge.sh |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Just one question about the group name that doesn't really matter. Is there a benefit or standard to the way it's named currently?
| "enabled": false | ||
| }, | ||
| { | ||
| "groupName": "non-pf-a11y-deps", |
There was a problem hiding this comment.
wdyt about a name like "grouped-pf-deps" or something less specific to the excluded package, in case we either yank another package out of the single renovate PR or add a new PF dep but don't want it in the PR?
There was a problem hiding this comment.
No benefit/standard to the current name, I just threw some words together, can change that rq.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/renovate.json (1)
22-36:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winConfiguration contradicts PR objective:
@patternfly/patternfly-a11yshould not be in this group.The PR title states "group non
@patternfly/patternfly-a11ydependency bumps", but this rule includes@patternfly/patternfly-a11yin thepackageNamesarray (line 26). This will group it with the other dependencies, contradicting the intended behavior.To achieve the stated objective, remove
@patternfly/patternfly-a11yfrom thepackageNamesarray in this rule. It will then be handled separately by the third rule (lines 37-42).🔧 Proposed fix
{ "groupName": "grouped-pf-deps", "datasources": ["npm"], "packageNames": [ - "`@patternfly/patternfly-a11y`", "`@patternfly/react-core`", "`@patternfly/react-icons`", "`@patternfly/react-code-editor`", "`@patternfly/react-table`", "`@patternfly/documentation-framework`", "sass", "stylelint*", "backstopjs" ] },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/renovate.json around lines 22 - 36, Remove the package "`@patternfly/patternfly-a11y`" from the packageNames array in the renovate rule named "grouped-pf-deps" so it is not grouped with the other PatternFly dependencies; locate the object with "groupName": "grouped-pf-deps" and delete the "`@patternfly/patternfly-a11y`" entry from its packageNames list so that the package will instead be matched by the separate rule handling `@patternfly/patternfly-a11y`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/renovate.json:
- Around line 37-42: The Renovate rule for "`@patternfly/patternfly-a11y`" is
being overridden/merged with the earlier rule that sets groupName:
"grouped-pf-deps", so this new rule won't ungroup it; fix by removing
"`@patternfly/patternfly-a11y`" from the earlier rule's packageNames (the rule
that specifies groupName: "grouped-pf-deps") so it is no longer matched there,
or explicitly set "groupName": null in the current rule for
"`@patternfly/patternfly-a11y`" to force ungrouping (reference the package name
"`@patternfly/patternfly-a11y`" and the key "groupName").
---
Outside diff comments:
In @.github/renovate.json:
- Around line 22-36: Remove the package "`@patternfly/patternfly-a11y`" from the
packageNames array in the renovate rule named "grouped-pf-deps" so it is not
grouped with the other PatternFly dependencies; locate the object with
"groupName": "grouped-pf-deps" and delete the "`@patternfly/patternfly-a11y`"
entry from its packageNames list so that the package will instead be matched by
the separate rule handling `@patternfly/patternfly-a11y`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: feb32f41-d1b6-4b13-9092-a6f3fa3c6bab
📒 Files selected for processing (1)
.github/renovate.json
|
🎉 This PR is included in version 6.5.0-prerelease.94 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Summary by CodeRabbit