Skip to content

fix(page): fix content bottom gap in glass - #8388

Merged
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8374
May 11, 2026
Merged

fix(page): fix content bottom gap in glass#8388
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8374

Conversation

@mcoker

@mcoker mcoker commented May 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #8374

Summary by CodeRabbit

  • Style
    • Improved glass theme display with refined main container height calculations for better visual consistency.

@mcoker
mcoker requested a review from jcmill May 8, 2026 22:38
@coderabbitai

coderabbitai Bot commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: fbaf0c89-5fb5-4ae9-8aae-edee87b52396

📥 Commits

Reviewing files that changed from the base of the PR and between 47bb454 and 1a8f3aa.

📒 Files selected for processing (1)
  • src/patternfly/components/Page/page.scss

Walkthrough

This PR adds a glass-theme-specific CSS variable for the Page component's main container max-height. A new --glass suffixed variable is defined based on page chrome inset, then wired to the standard MaxHeight token within the glass theme selector, ensuring the main container height respects the glass theme layout.

Changes

Glass Theme Container Height

Layer / File(s) Summary
Glass Theme Variable Definition
src/patternfly/components/Page/page.scss		 Introduces --#{$page}__main-container--MaxHeight--glass variable, computing main container max height from page chrome inset value.
Glass Theme Variable Wiring
src/patternfly/components/Page/page.scss		 In the glass theme selector block, assigns the newly defined glass-specific MaxHeight variable to the standard MaxHeight token.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • patternfly/patternfly#8274: Both PRs modify the Page component's SCSS to add and wire glass-theme-specific CSS variables for improved theme-aware layout behavior.

Suggested labels

released on @prerelease``

Suggested reviewers

  • jcmill
  • lboehling
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title follows conventional commit guidelines with proper 'fix' prefix, scope 'page', and a clear description of the fix.
Linked Issues check ✅ Passed The changes add glass-theme-specific MaxHeight token configuration to address the content spacing issue reported in #8374.
Out of Scope Changes check ✅ Passed All changes are scoped to the page.scss file and directly address the glass theme height adjustment requirement from the linked issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented May 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8388.surge.sh

A11y report: https://pf-pr-8388-a11y.surge.sh

jcmill
jcmill approved these changes May 9, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Looks great

@mcoker
mcoker merged commit 0f4f3d2 into patternfly:main May 11, 2026
5 checks passed
@mcoker
mcoker deleted the issue-8374 branch May 11, 2026 14:04
@patternfly-build

patternfly-build commented May 12, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.87 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request May 12, 2026
Closed
@coderabbitai coderabbitai Bot mentioned this pull request May 20, 2026
Merged
This was referenced Jul 17, 2026
Closed
Closed
@patternfly-build patternfly-build mentioned this pull request Jul 22, 2026
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 22, 2026
Open
@patternfly-build patternfly-build mentioned this pull request Jul 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcmill jcmill jcmill approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - page main content extends too low

3 participants

@mcoker @patternfly-build @jcmill