Skip to content

fix: update sticky toolbar shadow - #8377

Merged
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8376
May 7, 2026
Merged

fix: update sticky toolbar shadow#8377
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8376

Conversation

@mcoker

@mcoker mcoker commented May 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #8376

Summary by CodeRabbit

  • Style
    • Updated the box-shadow styling for the sticky Toolbar component to refine its visual appearance.

@mcoker
mcoker requested a review from lboehling May 7, 2026 00:22
@coderabbitai

coderabbitai Bot commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7324ca48-8bcd-4ec7-976b-31782e277e7b

📥 Commits

Reviewing files that changed from the base of the PR and between 960fb59 and aa53bb5.

📒 Files selected for processing (1)
  • src/patternfly/components/Toolbar/toolbar.scss

Walkthrough

Updates the Toolbar sticky mode's box-shadow CSS variable from the medium-bottom shadow token (--md--bottom) to the small-bottom shadow token (--sm--bottom), directly addressing the styling refinement identified in bug #8376.

Changes

Toolbar Sticky Box-Shadow Update

Layer / File(s) Summary
Sticky Shadow Token
src/patternfly/components/Toolbar/toolbar.scss		 The --#{$toolbar}--m-sticky--BoxShadow CSS variable is updated from --md--bottom to --sm--bottom box-shadow token.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • patternfly/patternfly#8321: Both PRs modify the Toolbar sticky box-shadow styling; this PR updates the token value while the related PR introduces/adjusts sticky box-shadow tokens.
  • patternfly/patternfly#8370: Both PRs update the sticky (.pf-m-sticky) variant styling in the same SCSS file.

Suggested labels

released on @prerelease``

Suggested reviewers

  • lboehling
  • jcmill
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: update sticky toolbar shadow' follows conventional commit guidelines with proper prefix and clearly describes the main change in the changeset.
Linked Issues check ✅ Passed The code changes directly implement the requirement from issue #8376: updating the toolbar sticky shadow from 'md-bottom' to 'sm-bottom' token.
Out of Scope Changes check ✅ Passed The changes are scoped to the toolbar sticky shadow styling and do not introduce unrelated modifications beyond the stated objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented May 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8377.surge.sh

A11y report: https://pf-pr-8377-a11y.surge.sh

lboehling
lboehling approved these changes May 7, 2026
View reviewed changes

@lboehling lboehling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks!

@mcoker
mcoker merged commit 0c19c32 into patternfly:main May 7, 2026
5 checks passed
@mcoker
mcoker deleted the issue-8376 branch May 7, 2026 19:56
@patternfly-build

patternfly-build commented May 7, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.85 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request Jun 15, 2026
Closed
1 of 3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Jul 15, 2026
Closed
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lboehling lboehling lboehling approved these changes
@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Update toolbar sticky shadow border

4 participants

@mcoker @patternfly-build @lboehling @thatblindgeye