Skip to content

fix(toolbar): sticky header should be pill in glass - #8370

Merged
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8369
May 6, 2026
Merged

fix(toolbar): sticky header should be pill in glass#8370
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-8369

Conversation

@mcoker

@mcoker mcoker commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

fixes #8369

This PR makes the regular "sticky toolbar" example (non-dynamic) pill shaped in glass.

Summary by CodeRabbit

  • Style
    • Enhanced the sticky toolbar's visual appearance with improved horizontal padding and rounded corners for better design consistency.

@mcoker
mcoker requested review from jcmill and lboehling May 5, 2026 23:09
@coderabbitai

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 52333cd1-450c-4885-a7e2-b09d3d8774f1

📥 Commits

Reviewing files that changed from the base of the PR and between a52bf78 and 2c30fdb.

📒 Files selected for processing (1)
  • src/patternfly/components/Toolbar/toolbar.scss

Walkthrough

The PR adds horizontal padding and border-radius styling to the Toolbar component's sticky state (.pf-m-sticky) in SCSS. Three CSS properties are introduced: padding-inline-start, padding-inline-end, and border-radius, implementing pill-style design requirements for sticky toolbars.

Changes

Toolbar Sticky State Styling

Layer / File(s) Summary
Sticky Toolbar Styling
src/patternfly/components/Toolbar/toolbar.scss		 Add padding-inline-start, padding-inline-end, and border-radius properties to the .pf-m-sticky selector to implement pill-style appearance. Existing vertical padding, border, and shadow properties remain unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • patternfly/patternfly#8321: Directly modifies the same Toolbar sticky-state SCSS with similar horizontal padding and border-radius adjustments.

Suggested labels

Needs design review

Suggested reviewers

  • jcmill
  • lboehling
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with 'fix' type and clear description of the sticky toolbar pill styling change.
Linked Issues check ✅ Passed The code changes add pill styling (border-radius, horizontal padding) to the sticky toolbar in glass theme, directly addressing issue #8369's requirement.
Out of Scope Changes check ✅ Passed All changes are scoped to the sticky toolbar styling in glass theme, directly related to the linked issue requirement with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8370.surge.sh

A11y report: https://pf-pr-8370-a11y.surge.sh

jcmill
jcmill approved these changes May 6, 2026
View reviewed changes

@jcmill jcmill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

@mcoker
mcoker merged commit b6900e6 into patternfly:main May 6, 2026
5 checks passed
@mcoker
mcoker deleted the issue-8369 branch May 6, 2026 16:27
@patternfly-build

patternfly-build commented May 6, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.83 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced May 7, 2026
Merged
Closed
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jun 15, 2026
Closed
1 of 3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Jun 24, 2026
Open
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcmill jcmill jcmill approved these changes
@lboehling lboehling Awaiting requested review from lboehling

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug - Toolbar - sticky style updates

3 participants

@mcoker @patternfly-build @jcmill