Skip to content

fix(pagination): glass inset bug - #8367

Merged
mcoker merged 3 commits into
patternfly:mainfrom
jcmill:fix/8361-pagination-inset-bug
May 7, 2026
Merged

fix(pagination): glass inset bug#8367
mcoker merged 3 commits into
patternfly:mainfrom
jcmill:fix/8361-pagination-inset-bug

Conversation

@jcmill

@jcmill jcmill commented May 5, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Closes #8361

Fixes pagination inset applying in glass theme by removing glass-specific InsetBlockStart and InsetBlockEnd overrides. Now Pagination uses the default inset values across all themes.

Summary by CodeRabbit

  • Style
    • Updated glass-theme pagination styling to centralize sticky state visuals: added glass-specific border-radius tokens, switched sticky corner radius and shadow to glass defaults, removed legacy inset overrides, and explicitly applied rounded corners to sticky pagination containers for consistent appearance.

@jcmill
jcmill requested review from andrew-ronaldson and mcoker May 5, 2026 15:51
@coderabbitai

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1f574385-03b2-4f53-8661-2581c9867a81

📥 Commits

Reviewing files that changed from the base of the PR and between 672513e and d2eff84.

📒 Files selected for processing (1)
  • src/patternfly/components/Pagination/pagination.scss
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/patternfly/components/Pagination/pagination.scss

Walkthrough

Adds a glass-specific sticky border-radius token, updates the glass-theme sticky radius and box-shadow to use glass defaults, and applies the sticky border-radius to the .pf-m-sticky container in pagination SCSS.

Changes

Pagination glass sticky tokens & wiring

Layer / File(s) Summary
Token addition
src/patternfly/components/Pagination/pagination.scss		 Adds --#{$pagination}--m-sticky--BorderRadius--glass glass-specific sticky border-radius token.
Glass-theme overrides
src/patternfly/components/Pagination/pagination.scss		 In glass-theme block, sets m-sticky-stuck--BorderRadius and m-sticky-stuck--BoxShadow to glass defaults and introduces m-sticky--BorderRadius sourced from the new glass token.
Sticky class application
src/patternfly/components/Pagination/pagination.scss		 Applies --#{$pagination}--m-sticky--BorderRadius to the .pf-m-sticky block so sticky state receives an explicit border-radius.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly Related PRs

  • patternfly/patternfly#8320: Modifies pagination.scss sticky-style custom properties and glass-theme overrides; closely related to sticky/glass token changes.
  • patternfly/patternfly#8370: Adjusts glass-theme sticky/pill-style border-radius and padding—related to glass sticky styling.

Suggested labels

released on @prerelease``

Suggested Reviewers

  • mcoker
  • lboehling
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit guidelines with 'fix' prefix and clear scope, accurately describing the pagination glass theme inset bug fix.
Linked Issues check ✅ Passed The PR addresses the core requirement from issue #8361 by removing glass-specific inset overrides to prevent unintended inset application in the glass theme.
Out of Scope Changes check ✅ Passed The changes focus on pagination glass theme styling adjustments including border radius and box-shadow tokens, with no unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8367.surge.sh

A11y report: https://pf-pr-8367-a11y.surge.sh

@andrew-ronaldson

andrew-ronaldson commented May 5, 2026

Copy link
Copy Markdown
Collaborator
Screenshot 2026-05-05 at 3 19 24 PM @lboehling should this get rounded corners like table headers?

@jcmill

jcmill commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson and @lboehling, I'll take a look at the figma files and see about adding it to the scope.

@jcmill

jcmill commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson, @lboehling and @mcoker... I filed off those sharp corners for ya.

@mcoker

mcoker commented May 7, 2026

Copy link
Copy Markdown
Contributor

@lboehling approved 👍

@mcoker
mcoker merged commit b06d57f into patternfly:main May 7, 2026
5 checks passed
@patternfly-build

patternfly-build commented May 7, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.85 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai Bot mentioned this pull request May 12, 2026
Closed
@jcmill
jcmill deleted the fix/8361-pagination-inset-bug branch May 13, 2026 15:13
This was referenced Jul 15, 2026
Closed
Merged
Open
This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes
@thatblindgeye thatblindgeye thatblindgeye approved these changes
@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

Pagination - inset being applied in glass

5 participants

@jcmill @patternfly-build @andrew-ronaldson @mcoker @thatblindgeye