Skip to content

chore(gulp): remove dev server rimraf - #8293

Merged
mcoker merged 1 commit into
patternfly:mainfrom
wise-king-sullyman:remove-dev-server-rimraf
Apr 8, 2026
Merged

chore(gulp): remove dev server rimraf#8293
mcoker merged 1 commit into
patternfly:mainfrom
wise-king-sullyman:remove-dev-server-rimraf

Conversation

@wise-king-sullyman

@wise-king-sullyman wise-king-sullyman commented Apr 8, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Removes a rimraf that was added previously to address a docs framework bug.

Summary by CodeRabbit

  • Chores
    • Removed automatic cleanup step that deleted the public directory when starting the development server.

@coderabbitai

coderabbitai Bot commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f06ecead-b967-4215-b4e5-03dd3f750b14

📥 Commits

Reviewing files that changed from the base of the PR and between 4e48a9c and 85ee0d5.

📒 Files selected for processing (1)
  • gulpfile.mjs
💤 Files with no reviewable changes (1)
  • gulpfile.mjs

Walkthrough

Removed an automatic cleanup step from the startWebpackDevServer() function in gulpfile.mjs that deleted the public directory after invoking the theme CLI start command. The function now executes only the dev server startup without subsequent directory removal.

Changes

Cohort / File(s) Summary
Build Configuration
gulpfile.mjs		 Removed rimraf() call that deleted the public directory after starting the webpack dev server.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit guidelines with a type prefix (chore), scope (gulp), and clear description of the change (remove dev server rimraf).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

mcoker
mcoker approved these changes Apr 8, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍗

@patternfly-build

patternfly-build commented Apr 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8293.surge.sh

A11y report: https://pf-pr-8293-a11y.surge.sh

@mcoker
mcoker merged commit deaddd1 into patternfly:main Apr 8, 2026
5 checks passed
@patternfly-build

patternfly-build commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.66 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wise-king-sullyman @patternfly-build @mcoker