Skip to content

chore(Button): updated times icon to RH micron close - #8282

Merged
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:fix/button-times-icon-to-rh-microns-close
Apr 6, 2026
Merged

chore(Button): updated times icon to RH micron close#8282
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:fix/button-times-icon-to-rh-microns-close

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Apr 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Closes #8283

Summary by CodeRabbit

  • Style
    • Updated button icon appearance in the Plain with text variation.

@thatblindgeye
thatblindgeye requested a review from mcoker April 6, 2026 17:21
@coderabbitai

coderabbitai Bot commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: cea86eb4-cde1-4449-99d1-a9b52df47005

📥 Commits

Reviewing files that changed from the base of the PR and between a444044 and 4c6c9c8.

📒 Files selected for processing (1)
  • src/patternfly/components/Button/button--variations.hbs

Walkthrough

Updated the "Plain with text" button variation template to replace the icon identifier from times to rh-microns-close, reflecting a change in the icon library or naming convention being used for the close icon.

Changes

Cohort / File(s) Summary
Button Variations
src/patternfly/components/Button/button--variations.hbs		 Replaced icon parameter value from times to rh-microns-close in the "Plain with text" button variation template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • mcoker
  • jcmill
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with appropriate scope and clear description of the icon replacement change.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8282.surge.sh

A11y report: https://pf-pr-8282-a11y.surge.sh

mcoker
mcoker approved these changes Apr 6, 2026
View reviewed changes

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏰⏰⏰

@mcoker
mcoker merged commit 7899d17 into patternfly:main Apr 6, 2026
5 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 6, 2026
Closed
@patternfly-build

patternfly-build commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.66 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 22, 2026
Closed
Closed
@coderabbitai coderabbitai Bot mentioned this pull request Jul 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update times icon in button example to RH microns close

3 participants

@thatblindgeye @patternfly-build @mcoker