Skip to content

fix(DualListSelector): added accessible name back to buttons - #8194

Merged
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:dls_SortBtnLabel
Mar 2, 2026
Merged

fix(DualListSelector): added accessible name back to buttons#8194
mcoker merged 1 commit into
patternfly:mainfrom
thatblindgeye:dls_SortBtnLabel

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Mar 2, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved Sort button accessibility with aria-label attribute support.

@coderabbitai

coderabbitai Bot commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66c6d91 and 01b1ee4.

📒 Files selected for processing (1)
  • src/patternfly/components/DualListSelector/dual-list-selector--actions.hbs

Walkthrough

The Sort button in the Dual List Selector component receives an aria-label attribute set to "Sort", enhancing accessibility for screen readers while maintaining existing button properties.

Changes

Cohort / File(s) Summary
Dual List Selector Accessibility
src/patternfly/components/DualListSelector/dual-list-selector--actions.hbs		 Added aria-label="Sort" attribute to the Sort button for improved screen reader support.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows conventional commit format with 'fix' prefix and clearly describes the change: adding accessible names back to buttons in DualListSelector.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@patternfly-build

patternfly-build commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Preview: https://pf-pr-8194.surge.sh

A11y report: https://pf-pr-8194-a11y.surge.sh

@mcoker
mcoker merged commit 26c508b into patternfly:main Mar 2, 2026
5 checks passed
@patternfly-build

patternfly-build commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jul 22, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes
@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@thatblindgeye @patternfly-build @wise-king-sullyman @mcoker