Skip to content

fix(icons): replace close icon with rh micron close icon - #8174

Merged
mcoker merged 4 commits into
patternfly:mainfrom
srambach:8172-close-buttons-to-micron
Feb 28, 2026
Merged

mcoker merged 4 commits into
patternfly:mainfrom
srambach:8172-close-buttons-to-micron

Conversation

@srambach

@srambach srambach commented Feb 26, 2026 •

Copy link
Copy Markdown
Member

Fixes #8172

Summary by CodeRabbit

  • Style
    • Standardized close/clear icons across the UI to the new "rh-microns-close" design. Applies to modals, alerts, drawers, labels, popovers, tabs, menus, input groups, toolbars, wizards, notifications, file uploads, and demos for a consistent close/clear button appearance.

@coderabbitai

coderabbitai Bot commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (117)
  • backstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_with-drawer_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__ai_generative-uis_compass_html-demos_with-drawer_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_about-modal_html-demos_basic_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_about-modal_html-demos_basic_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_about-modal_html_basic_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_about-modal_html_basic_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_action-list-with-icons_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_action-list-with-icons_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_action-list-with-icons_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_vertical-action-list_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_vertical-action-list_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_action-list_html_vertical-action-list_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html-demos_toast_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html-demos_toast_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html-demos_toast_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_expandable_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_expandable_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_expandable_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_inline-variations_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_inline-variations_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_inline-variations_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_toast-alert-group_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_toast-alert-group_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_toast-alert-group_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_variations_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_variations_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_alert_html_variations_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_card_html-demos_status-card-expanded-with-popover_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_description-list_html-demos_in-drawer_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_description-list_html-demos_in-drawer_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html-demos_expanded-drawer-with-jump-links_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html-demos_expanded-drawer-with-jump-links_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_additional-section-above-main_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_additional-section-above-main_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-inline-panel-on-left_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-inline-panel-on-left_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-inline-panel_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-inline-panel_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-bottom_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-bottom_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-left_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-left_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-right_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_expanded-panel-on-right_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-content-body-padding_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-content-body-padding_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-panel-body-padding_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-panel-body-padding_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-panel-width_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_modified-panel-width_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_panel-with-secondary-background_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_panel-with-secondary-background_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_pill-inline_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_pill-inline_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_pill_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_pill_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-bottom-panel_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-bottom-panel_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-inline-panel_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-inline-panel_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-left-panel_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-left-panel_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-panel_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_resizable-panel_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_stacked-content-body-elements_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_stacked-content-body-elements_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_static_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_drawer_html_static_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_file-upload-status-expanded_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_file-upload-status-expanded_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_file-upload-status-expanded_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_horizontal-file-upload-status-expanded_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_horizontal-file-upload-status-expanded_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_file-upload_multiple-file-upload_html_horizontal-file-upload-status-expanded_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_inline-edit-action-group-icon-buttons_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_inline-edit-action-group-icon-buttons_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_inline-edit-action-group-icon-buttons_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_inline-edit-table-row_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_inline-edit-table-row_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_single-inline-edit-active_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_single-inline-edit-active_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_single-inline-edit-active_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_state-invalid_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_state-invalid_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_state-valid_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_state-valid_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_inline-edit_html_state-valid_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_jump-links_html-demos_jump-links-in-expanded-drawer_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_jump-links_html-demos_jump-links-in-expanded-drawer_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_compact_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_compact_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_compact_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_editable_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_editable_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_filled_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_filled_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_filled_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_label-group-with-removable-categories_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_outline_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_outline_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_outline_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_static-labels-dynamic-label-group_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_label_html_vertical-label-group-with-removable-category_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_masthead_html-demos_with-expandable-search-expanded_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_masthead_html-demos_with-expandable-search-expanded_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_menus_menu-toggle_html_typeahead_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_menus_menu-toggle_html_typeahead_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_menus_menu-toggle_html_typeahead_0_document_2_desktop.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_basic_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_basic_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_large_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_large_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_medium_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_medium_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_modal-with-form_0_document_0_mobile.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_modal-with-form_0_document_1_tablet.png is excluded by !**/*.png
  • backstop_data/bitmaps_reference/pf-core__components_modal_html-demos_scrollable-content_0_document_0_mobile.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Replaces Font Awesome "times" close icons with the rh-microns-close icon across multiple PatternFly component templates and documentation examples; no logic, structure, or control flow changes.

Changes

Cohort / File(s) Summary
Close button templates
src/patternfly/components/Drawer/drawer-close.hbs, src/patternfly/components/ModalBox/modal-box-close.hbs, src/patternfly/components/Popover/popover-close.hbs, src/patternfly/components/Wizard/wizard-close.hbs, src/patternfly/components/NotificationDrawer/notification-drawer-header-action-close.hbs, src/patternfly/components/MultipleFileUpload/multiple-file-upload-status-item-close.hbs
Icon swapped from "times" to "rh-microns-close" in component close button templates.
Action / utility button templates
src/patternfly/components/InlineEdit/inline-edit-action-cancel.hbs, src/patternfly/components/Tabs/tabs-item-action.hbs, src/patternfly/components/MenuToggle/menu-toggle-clear.hbs
Close/clear icons updated; some raw <i> elements converted to {{pfIcon "rh-microns-close"}}.
Label-related templates
src/patternfly/components/Label/label.hbs, src/patternfly/components/Label/label-group-close.hbs, src/patternfly/components/Toolbar/templates/toolbar--item-label-group.hbs
Remove/label-action icons changed to rh-microns-close.
Text input / search templates
src/patternfly/components/TextInputGroup/text-input-group--search-input.hbs, src/patternfly/components/MenuToggle/examples/MenuToggle.md
Clear/search input clear icons replaced with rh-microns-close (includes template param update).
Component documentation examples
src/patternfly/components/AboutModalBox/examples/AboutModalBox.md, src/patternfly/components/ActionList/examples/ActionList.md, src/patternfly/components/Alert/examples/Alert.md, src/patternfly/components/TextInputGroup/examples/TextInputGroup.md, src/patternfly/components/MenuToggle/examples/MenuToggle.md
Example markdown updated to reference rh-microns-close instead of times in various examples.
Demos
src/patternfly/demos/AboutModal/about-modal-template.hbs, src/patternfly/demos/Alert/examples/Alert.md, src/patternfly/demos/Masthead/examples/Masthead.md
Demo templates/examples updated to use rh-microns-close for close buttons.
Other
src/patternfly/components/ActionList/..., src/patternfly/components/Alert/..., src/patternfly/components/TextInputGroup/... (multiple files)
Widespread icon name replacements from times / times fa-fw to rh-microns-close across additional component example files and variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

released on @prerelease``

Suggested reviewers

  • kmcfaul
  • mcoker
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title follows conventional commit format with 'fix' type and descriptive scope, clearly summarizing the main change of replacing close icons.
Linked Issues check ✅ Passed The PR successfully implements the requirement from issue #8172 to replace all fa-times close icons with rh-microns-close across multiple components.
Out of Scope Changes check ✅ Passed All changes are directly related to the icon replacement objective; no unrelated or out-of-scope modifications were introduced.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/patternfly/components/Alert/examples/Alert.md`:
- Line 469: Two toast examples use the success-specific aria-label in the
close-button partial invocation (the string starting with {{> button
button--IsPlain=true button--attribute='aria-label="Close success alert: Success
alert title"'}}); update those two occurrences so the aria-label matches the
toast type — e.g., change to aria-label="Close danger alert: Danger alert title"
for the danger toast and aria-label="Close info alert: Info alert title" for the
info toast — leaving other attributes (button--IsPlain, button--IsIcon,
button--icon) unchanged.

In `@src/patternfly/components/TextInputGroup/examples/TextInputGroup.md`:
- Around line 109-113: The icon class "fas fa-rh-microns-close" used inside the
text-input-group-utilities partial is invalid and will not render; update the
<i> element inside the {{#> text-input-group-utilities}} block (the button
partial invocation with button--modifier="pf-m-plain" and aria-label="Clear
input") to use a valid icon class (e.g., a correct Font Awesome close icon class
or the project’s PatternFly icon class) or swap to the button partial pattern
suggested in the comment so the clear icon renders correctly.
- Around line 94-98: The icon class in the text-input-group-utilities example is
invalid (uses Font Awesome prefix with a PatternFly icon) and prevents
rendering; update the nested button (the {{#> button ...}} block with
aria-label="Clear error validation example") to use the same PatternFly icon
pattern used elsewhere in this repo—remove the "fas fa-rh-microns-close" class
and replace it with the PatternFly icon usage (either the icon partial/component
or the correct PatternFly icon class used in other examples) so the icon renders
consistently with other examples.

ℹ️ Review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7c7d97 and 015b0b2.

📒 Files selected for processing (21)
  • src/patternfly/components/AboutModalBox/examples/AboutModalBox.md
  • src/patternfly/components/ActionList/examples/ActionList.md
  • src/patternfly/components/Alert/examples/Alert.md
  • src/patternfly/components/Drawer/drawer-close.hbs
  • src/patternfly/components/InlineEdit/inline-edit-action-cancel.hbs
  • src/patternfly/components/Label/label-group-close.hbs
  • src/patternfly/components/Label/label.hbs
  • src/patternfly/components/MenuToggle/examples/MenuToggle.md
  • src/patternfly/components/MenuToggle/menu-toggle-clear.hbs
  • src/patternfly/components/ModalBox/modal-box-close.hbs
  • src/patternfly/components/MultipleFileUpload/multiple-file-upload-status-item-close.hbs
  • src/patternfly/components/NotificationDrawer/notification-drawer-header-action-close.hbs
  • src/patternfly/components/Popover/popover-close.hbs
  • src/patternfly/components/Tabs/tabs-item-action.hbs
  • src/patternfly/components/TextInputGroup/examples/TextInputGroup.md
  • src/patternfly/components/TextInputGroup/text-input-group--search-input.hbs
  • src/patternfly/components/Toolbar/templates/toolbar--item-label-group.hbs
  • src/patternfly/components/Wizard/wizard-close.hbs
  • src/patternfly/demos/AboutModal/about-modal-template.hbs
  • src/patternfly/demos/Alert/examples/Alert.md
  • src/patternfly/demos/Masthead/examples/Masthead.md

Comment thread src/patternfly/components/Alert/examples/Alert.md Outdated
Comment thread src/patternfly/components/TextInputGroup/examples/TextInputGroup.md
Comment thread src/patternfly/components/TextInputGroup/examples/TextInputGroup.md
@patternfly-build

patternfly-build commented Feb 26, 2026 •

Copy link
Copy Markdown
Collaborator

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
src/patternfly/components/TextInputGroup/examples/TextInputGroup.md (1)

109-113: ⚠️ Potential issue | 🟠 Major

Same inconsistency: use button partial pattern.

This has the same issue as lines 94-98. The nested button block with raw <i> element should be replaced with the consistent button partial pattern.

♻️ Proposed fix
-  {{#> text-input-group-utilities}}
-    {{#> button button--modifier="pf-m-plain" button--attribute='aria-label="Clear input"'}}
-      <i class="rh-microns-close" aria-hidden="true"></i>
-    {{/button}}
-  {{/text-input-group-utilities}}
+  {{#> text-input-group-utilities}}
+    {{> button button--IsPlain=true button--IsIcon=true button--icon="rh-microns-close" button--attribute='aria-label="Clear input"'}}
+  {{/text-input-group-utilities}}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/patternfly/components/TextInputGroup/examples/TextInputGroup.md` around
lines 109 - 113, Replace the nested raw <i> element inside the
text-input-group-utilities block with the consistent button partial pattern used
elsewhere: update the block under {{#> text-input-group-utilities}} to invoke
the {{#> button}} partial (same button--modifier and aria-label attributes) but
use the button partial's icon slot/partial instead of embedding raw HTML; locate
the occurrences of the text-input-group-utilities and button partials in this
file and mirror the implementation used around lines 94-98 so the icon is
rendered via the button partial pattern rather than a raw <i> tag.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@src/patternfly/components/TextInputGroup/examples/TextInputGroup.md`:
- Around line 109-113: Replace the nested raw <i> element inside the
text-input-group-utilities block with the consistent button partial pattern used
elsewhere: update the block under {{#> text-input-group-utilities}} to invoke
the {{#> button}} partial (same button--modifier and aria-label attributes) but
use the button partial's icon slot/partial instead of embedding raw HTML; locate
the occurrences of the text-input-group-utilities and button partials in this
file and mirror the implementation used around lines 94-98 so the icon is
rendered via the button partial pattern rather than a raw <i> tag.

ℹ️ Review info

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 015b0b2 and ebfaa7f.

📒 Files selected for processing (2)
  • src/patternfly/components/Alert/examples/Alert.md
  • src/patternfly/components/TextInputGroup/examples/TextInputGroup.md

@mcoker
mcoker force-pushed the 8172-close-buttons-to-micron branch from ebfaa7f to 6add807 Compare February 28, 2026 02:06
@mcoker

mcoker commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoker
mcoker merged commit 81619a5 into patternfly:main Feb 28, 2026
4 of 5 checks passed
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.5.0-prerelease.46 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update close icons to rh-icons

3 participants