fix(tabs): move box border rendering to tab item - #8160
Open
tarunvashishth wants to merge 1 commit into
Open
tarunvashishth wants to merge 1 commit into
tarunvashishth wants to merge 1 commit into
Conversation
Collaborator
|
Preview: https://pf-pr-8160.surge.sh A11y report: https://pf-pr-8160-a11y.surge.sh |
|
This PR has been automatically marked as stale because it has not had activity in the last 60 days. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7863
This change moves box variant border rendering from the tab link/button pseudo-element to the parent tab item pseudo-element, so the link pseudo-element can be used for high-contrast interactive borders with the correct plain-action tokens.
src/patternfly/components/Tabs/tabs.scss:101src/patternfly/components/Tabs/tabs.scss:300src/patternfly/components/Tabs/tabs.scss:356src/patternfly/components/Tabs/tabs.scss:463.__tabs__item::before:src/patternfly/components/Tabs/tabs.scss:589.__tabs__item::before:src/patternfly/components/Tabs/tabs.scss:629src/patternfly/components/Tabs/tabs.scss:529:has(...):src/patternfly/components/Tabs/tabs.scss:609::beforeto draw high-contrast interactive border from link tokens:src/patternfly/components/Tabs/tabs.scss:685src/patternfly/components/Tabs/tabs.scss:69src/patternfly/components/Tabs/tabs.scss:71src/patternfly/components/Tabs/tabs.scss:73src/patternfly/components/Tabs/tabs.scss:198Assisted by: GitHub Copilot.