fix(drawer): adjust pill for rtl and widths - #7981
Conversation
|
Preview: https://pf-pr-7981.surge.sh A11y report: https://pf-pr-7981-a11y.surge.sh |
mcoker
left a comment
mcoker
left a comment
There was a problem hiding this comment.
Looks like the reason the inline pill drawer isn't responding to the .pf-m-width modifiers is because this var's value doesn't have a unit and is used in a calc() https://github.com/srambach/patternfly/blob/f14de9bde750ad33ab6217ea8683f216d6d224cb/src/patternfly/components/Drawer/drawer.scss#L218
Also looked at the react component and it sets --pf-v6-c-drawer__panel--md--FlexBasis--min and --pf-v6-c-drawer__panel--md--FlexBasis--max inline via minSize and maxSize props, so a combo of minSize: {some ideal size} and maxSize: 100% is a valid use case. IMO that's more work than this issue needs. The percentage based width classes work and that should be good enough.
I'd be good with a follow-up that looks at what happens when you use --FlexBasis, --FlexBasis--min, and --FlexBasis--max, and also tests resizable since I don't think that's been looked at yet, either. wdyt?
|
f14de9b to
3c5d99e
Compare
|
🎉 This PR is included in version 6.5.0-prerelease.31 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 participants
Fixes #7947
Uses the pill drawer inset to adjust
Formula syntax assisted by Claude code