feat(compass): added component - #7927
Conversation
|
Preview: https://pf-pr-7927.surge.sh A11y report: https://pf-pr-7927-a11y.surge.sh |
7f4742d to
4c692b6
Compare
thatblindgeye
left a comment
thatblindgeye
left a comment
There was a problem hiding this comment.
The file comments below this may not necessarily be anything to resolve right now, more thoughts I had looking this over. Let me know what you think.
| @@ -0,0 +1,6 @@ | |||
| <div class="{{pfv}}compass__footer{{#if compass-footer--modifier}} {{compass-footer--modifier}}{{/if}}" | |||
There was a problem hiding this comment.
So I'm wondering whether some of these components should use their semantic elements (footer element here, and header and main elsewhere).
Issue is the compass__panel components living outside header, footer, and main. I'm not sure if putting them in aside elements would make the most sense (they sorta do I think).
Probably fine to leave them as plain divs for now, but worth mulling over some more, especially because I assume we need (or at least want) the structure of Compass to be as it is now: header, panel, main, panel, and footer all being adjacent siblings (rather than main containing the 2 panels).
|
🎉 This PR is included in version 6.5.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
fixes #7909