fix(drawer): fix primary-detail pattern drawer header - #7904
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7904.surge.sh A11y report: https://pf-pr-7904-a11y.surge.sh |
mcoker
requested changes
Oct 22, 2025
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
Nice use of the drawer description!
Looks like there are a couple more
-
Wizard "With drawer" demo has
drawer-bodyarounddrawer-head
patternfly/src/patternfly/demos/Wizard/examples/Wizard.md
Lines 210 to 217 in 9b4a99e
-
Wizard "with drawer" example has
drawer-bodyarounddrawer-headalong with some other issues- text usually comes before actions
drawer-headerdoesn't exist
patternfly/src/patternfly/components/Wizard/examples/Wizard.md
Lines 197 to 206 in 9b4a99e
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edonehoo
pushed a commit
to edonehoo/patternfly
that referenced
this pull request
Nov 11, 2025
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7803
• Fixed CSS typo:
pf-m-paddinng→pf-m-paddingin drawer-body.hbs• Removed unnecessary attribute:
drawer-body--HasPadding=truefrom Drawer.md example• Fixed drawer nesting: Moved
drawer-headout ofdrawer-bodyin page-template-drawer-panel.hbs• Simplified header structure: Removed unnecessary flex layout in primary-detail-template-panel-header.hbs. It now uses
drawer-headanddrawer-descriptionelements properly.Just the description generated by cursor 😺