fix(Button): updated AriaExpanded to apply correctly - #7893
Merged
thatblindgeye merged 1 commit intoOct 15, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7893.surge.sh A11y report: https://pf-pr-7893-a11y.surge.sh |
mcoker
approved these changes
Oct 15, 2025
Collaborator
|
🎉 This PR is included in version 6.4.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edonehoo
pushed a commit
to edonehoo/patternfly
that referenced
this pull request
Nov 11, 2025
Co-authored-by: Eric Olkowski <[email protected]>
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7892
Tried going for the quicker solution for now:
ifblock for button--AriaExpanded uses the concat helper; this should apply aria-expanded correctly when button--AriaExpanded is passed a boolean false value as well as a truthy valueJust need douible checked in reivew:
things(true when expanded, false when collapsed)thingisn't expandable (e.g. a basic primary button shouldn't have aria-expanded)I also added a comment for the concat helper I added for now, I think we could probably have a followup to clean up how we're passing in button--AriaExpanded based on other component attributes (e.g. jump-links--IsExpanded is explicitly passed a stringy "true", but needs to be passed a boolean
falseotherwise a stringy "false" will setpf-m-expandedon the jump links.