fix(dual-list-selector): fix overflow of items - #7861
Merged
mcoker merged 2 commits intoSep 23, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7861.surge.sh A11y report: https://pf-pr-7861-a11y.surge.sh |
mcoker
self-requested a review
September 23, 2025 15:26
mcoker
reviewed
Sep 23, 2025
| .#{$dual-list-selector}__item, | ||
| .#{$dual-list-selector}__item-main { | ||
| flex-basis: 100%; | ||
| flex-basis: 100%; // TODO |
Contributor
There was a problem hiding this comment.
wdyt about replacing this with flex-grow: 1? Seems like that might be more predictable than using a percentage based size just to ensure the element takes up the available space by default.
Also did you mean to leave the TODO comment?
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.75 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edonehoo
pushed a commit
to edonehoo/patternfly
that referenced
this pull request
Nov 11, 2025
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7854