fix(switch): adds borders to make visible in forced colors - #7847
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7847.surge.sh A11y report: https://pf-pr-7847-a11y.surge.sh |
lboehling
approved these changes
Sep 23, 2025
mcoker
approved these changes
Sep 23, 2025
Contributor
There was a problem hiding this comment.
❤️ it. Disabled switches are disabled, so you can't focus them, and they're read as disabled to assistive tech. Also we have the "not allowed" cursor on hover when they're disabled, though it would be great to have an alternate display so it's more visible that they're disabled. We can address that if/when we go for full support in forced-colors mode.
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.76 🎉 The release is available on: Your semantic-release bot 📦🚀 |
edonehoo
pushed a commit
to edonehoo/patternfly
that referenced
this pull request
Nov 11, 2025
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7834
Also adds a border around disabled switches in high-contrast mode. (previously they only showed up on switches that were turned off.)
Note that disabled switches are currently not really distinguishable in forced-colors: active but I don't know another solution. For now it will have to rely on behavior (cursor etc)
@lboehling please take a look!