fix(button): remove border width animation - #7832
Merged
mcoker merged 1 commit intoSep 15, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7832.surge.sh A11y report: https://pf-pr-7832-a11y.surge.sh |
mcoker
approved these changes
Sep 15, 2025
lboehling
approved these changes
Sep 15, 2025
lboehling
left a comment
lboehling
left a comment
There was a problem hiding this comment.
this feels so much smoother to me across the board -- always felt like the border transition felt a little jumpy!
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.71 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7743
After experimentation, it seems that the perceived jankiness in the plain button hover animation was because we are animating in a 1px border. Because it's simply going from 0 to 1px, there is very room for intermediate states and so it seems jumpy. I've removed border-width from the transition properties. Now the plain button (and other) button borders will animate in based just on the color, but this seems to have a smoother feel.