fix(tabs): add side borders to selected box tab in high contrast - #7809
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7809.surge.sh A11y report: https://pf-pr-7809-a11y.surge.sh |
mcoker
reviewed
Sep 8, 2025
Comment on lines
+318
to
+321
| --#{$tabs}__link--before--BorderInlineStartColor: var(--#{$tabs}__link--m-current--before--BorderInlineStartColor); | ||
| --#{$tabs}__link--before--BorderInlineStartWidth: var(--#{$tabs}__link--m-current--before--BorderInlineStartWidth); | ||
| --#{$tabs}__link--before--BorderInlineEndColor: var(--#{$tabs}__link--m-current--before--BorderInlineEndColor); | ||
| --#{$tabs}__link--before--BorderInlineEndWidth: var(--#{$tabs}__link--m-current--before--BorderInlineEndWidth); |
Contributor
There was a problem hiding this comment.
Can you put --m-box in front of these? The vars before them are set to --m-box vars but for whatever reason they're declared above and down here...
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.63 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7798
NOTE: This exposes that the current tab decorator (blue line) is 1px too long on the left side. It comes from line 110, and I think this could be removed along with a couple of other lines - it will break visual regression tests but is also technically a bug fix. I have NOT included it here until confirmation that it's truly not needed and we want to make the change.
--#{$tabs}__link--before--InsetInlineStart: calc(var(--#{$tabs}__link--before--border-width--base) * -1);