Skip to content

feat(banner): add high contrast border - #7762

Merged
mcoker merged 2 commits into
patternfly:high-contrast-q3from
srambach:7589-banner-hi-c
Aug 27, 2025
Merged

mcoker merged 2 commits into
patternfly:high-contrast-q3from
srambach:7589-banner-hi-c

Conversation

@srambach

Copy link
Copy Markdown
Member

Fixes #7589

Adds a top and bottom border as a compromise to handle a banner at the top or bottom of either a full page or the content area (or elsewhere).

@patternfly-build

patternfly-build commented Aug 26, 2025 •

Copy link
Copy Markdown
Collaborator

@mcoker
mcoker requested a review from lboehling August 26, 2025 20:52

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing about the border color.

Also worth mentioning if the banner is somewhere else, it would look similar to this

Screenshot 2025-08-26 at 3 55 24 PM

Comment thread src/patternfly/components/Banner/banner.scss Outdated
@srambach srambach linked an issue Aug 26, 2025 that may be closed by this pull request

@lboehling lboehling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcoker
mcoker merged commit 5c0af48 into patternfly:high-contrast-q3 Aug 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High contrast borders - Banner

4 participants