chore(login): fix header markup in main element - #7753
Merged
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7753.surge.sh A11y report: https://pf-pr-7753-a11y.surge.sh |
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
This is what React currently looks like on Org:
React also doesn't allow customizing the elements for the header, main, or footer components that use those tags (login__main, __footer, and __header classes). Looks like we updated the stuff inside that main element to be hardcoded divs now (the __main-header, and __main-footer classes; __main-body was already a div).
This PR only updates the header component in Core to be a div, but we'd still have footer tag being used for __main-footer.
thatblindgeye
approved these changes
Aug 29, 2025
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.54 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6928