fix(codeeditor): added header border - #7738
Conversation
|
Preview: https://pf-pr-7738.surge.sh A11y report: https://pf-pr-7738-a11y.surge.sh |
srambach
left a comment
There was a problem hiding this comment.
This looks great. It is technically a visual breaking change, unless we are considering it a bug (which could be fair).
|
@srambach good callout. I'm good with it, @lboehling wdyt? Is there anyone else we might want to run this change by in terms of whether this will be disruptive or cause issues? As an example, we include the code editor's "header" after each of our code examples that will then expand to a full code editor window if you click on the language button, so now that box has borders and rounded corners on the top. I'm not even sure if that's a recommended use of the code editor, but if a product did something similar, that may be something they'd want to review/update when pulling in this version of PF (which is what makes it "breaking")
|
|
@mcoker i love the suggestion you just mocked up for the code editor example. IMO, that has always felt like a weird behavior/misuse of the code editor header on our doc site. We could ask others during office hours if they know of any other product that uses a collapsed code editor in that way? |


fixes #7615