Skip to content

fix(codeeditor): added header border - #7738

Merged
mcoker merged 1 commit into
patternfly:high-contrast-q3from
mcoker:issue-7615
Aug 18, 2025
Merged

mcoker merged 1 commit into
patternfly:high-contrast-q3from
mcoker:issue-7615

Conversation

@mcoker

@mcoker mcoker commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

fixes #7615

@mcoker
mcoker requested review from lboehling and srambach August 12, 2025 23:34
@patternfly-build

patternfly-build commented Aug 12, 2025 •

Copy link
Copy Markdown
Collaborator

@lboehling lboehling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@srambach srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. It is technically a visual breaking change, unless we are considering it a bug (which could be fair).

@mcoker
mcoker merged commit d8807bd into patternfly:high-contrast-q3 Aug 18, 2025
@mcoker
mcoker deleted the issue-7615 branch August 18, 2025 20:55
@mcoker

mcoker commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

@srambach good callout. I'm good with it, @lboehling wdyt? Is there anyone else we might want to run this change by in terms of whether this will be disruptive or cause issues?

As an example, we include the code editor's "header" after each of our code examples that will then expand to a full code editor window if you click on the language button, so now that box has borders and rounded corners on the top. I'm not even sure if that's a recommended use of the code editor, but if a product did something similar, that may be something they'd want to review/update when pulling in this version of PF (which is what makes it "breaking")

Screenshot 2025-08-18 at 3 58 29 PM

@mcoker

mcoker commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

I just hacked this together but I wonder if something like this might help the design and be a nudge to users that there is code from that list of buttons

Screenshot 2025-08-18 at 4 11 09 PM

@lboehling

Copy link
Copy Markdown

@mcoker i love the suggestion you just mocked up for the code editor example. IMO, that has always felt like a weird behavior/misuse of the code editor header on our doc site. We could ask others during office hours if they know of any other product that uses a collapsed code editor in that way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants