chore(hint): update kebab toggle aria labels - #7715
Merged
thatblindgeye merged 2 commits intoAug 13, 2025
Merged
Conversation
Collaborator
|
Preview: https://pf-pr-7715.surge.sh A11y report: https://pf-pr-7715-a11y.surge.sh |
thatblindgeye
requested changes
Aug 12, 2025
thatblindgeye
left a comment
thatblindgeye
left a comment
Contributor
There was a problem hiding this comment.
Just some quick suggestions below - we don't really need to include the words "kebab toggle" here, instead replacing that with "actions". The semantic role and state of the button should provide the context that it's a toggle (and kebab really only describes the icon, though depending on the context/user that could also be a good identifier as kebab may == "actions menu").
| menu-toggle--HasKebab=true | ||
| menu-toggle--id=(dasherize hint--id 'hint') | ||
| menu-toggle--aria-label='Hint menu toggle' | ||
| menu-toggle--aria-label='Hint with title example kebab toggle' |
Contributor
There was a problem hiding this comment.
Suggested change
| menu-toggle--aria-label='Hint with title example kebab toggle' | |
| menu-toggle--aria-label='Hint with title example actions' |
| menu-toggle--HasKebab=true | ||
| menu-toggle--id=(dasherize hint--id 'hint') | ||
| menu-toggle--aria-label='Hint menu toggle' | ||
| menu-toggle--aria-label='Hint with title example kebab toggle' |
Contributor
There was a problem hiding this comment.
Suggested change
| menu-toggle--aria-label='Hint with title example kebab toggle' | |
| menu-toggle--aria-label='Hint with title and footer example actions' |
| menu-toggle--HasKebab=true | ||
| menu-toggle--id=(dasherize hint--id 'hint') | ||
| menu-toggle--aria-label='Hint menu toggle' | ||
| menu-toggle--aria-label='Hint without title example kebab toggle' |
Contributor
There was a problem hiding this comment.
Suggested change
| menu-toggle--aria-label='Hint without title example kebab toggle' | |
| menu-toggle--aria-label='Hint without title example actions' |
thatblindgeye
approved these changes
Aug 13, 2025
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.50 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7283