Conversation
Collaborator
|
Preview: https://pf-pr-7695.surge.sh A11y report: https://pf-pr-7695-a11y.surge.sh |
wise-king-sullyman
requested review from
a team,
lboehling,
sg00dwin and
srambach
and removed request for
a team and
sg00dwin
July 29, 2025 18:30
srambach
reviewed
Jul 29, 2025
| pointer-events: none; | ||
| content: ''; | ||
| border: var(--#{$progress}__bar--BorderWidth) solid var(--#{$progress}__bar--BorderColor); | ||
| border-radius: var(--#{$progress}__bar--BorderRadius); |
Member
Contributor
There was a problem hiding this comment.
Oops! Didn't see your review, left the same comment below
Collaborator
Author
There was a problem hiding this comment.
Looks like one of you owes the other a soda 😆
mcoker
approved these changes
Jul 29, 2025
mcoker
left a comment
mcoker
left a comment
Contributor
There was a problem hiding this comment.
LGTM just one small nit - ::before can inherit values from the element it applies to, so we can use inherit for the value of border-radius. Just one less var to keep track of.
Co-authored-by: Michael Coker <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7604
figma
Convenience link: https://pf-pr-7695.surge.sh/components/progress