Skip to content

feat(codeBlock): added high contrast border - #7685

Merged
mcoker merged 2 commits into
patternfly:high-contrast-q3from
rebeccaalpert:issue-7597
Jul 28, 2025
Merged

mcoker merged 2 commits into
patternfly:high-contrast-q3from
rebeccaalpert:issue-7597

Conversation

@rebeccaalpert

@rebeccaalpert rebeccaalpert commented Jul 24, 2025 •

Copy link
Copy Markdown
Member

Commented in bit about :root:where(.pf-v6-theme-high-contrast) { and added it to root to check.

I added these tokens following Sarah's example in the modal PR, but let me know if you don't want these tokens here. I don't see them in the tokens table.

Before After
Screenshot 2025-07-24 at 1 47 40 PM Screenshot 2025-07-25 at 9 35 55 AM
Before After
Screenshot 2025-07-24 at 1 47 46 PM Screenshot 2025-07-24 at 1 43 33 PM

@rebeccaalpert rebeccaalpert linked an issue Jul 24, 2025 that may be closed by this pull request
@patternfly-build

patternfly-build commented Jul 24, 2025 •

Copy link
Copy Markdown
Collaborator

@rebeccaalpert
rebeccaalpert changed the base branch from main to high-contrast-q3 July 24, 2025 17:54
@rebeccaalpert
rebeccaalpert force-pushed the issue-7597 branch 3 times, most recently from a22471f to f49af3b Compare July 24, 2025 18:01

@mcoker mcoker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One small change, just one nit. It's one less var to keep track of since ::before and ::after can inherit border-radius from their parent element.

Comment thread src/patternfly/components/CodeBlock/code-block.scss Outdated
@mcoker
mcoker marked this pull request as ready for review July 25, 2025 21:03
@mcoker
mcoker merged commit 3d48d04 into patternfly:high-contrast-q3 Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High contrast borders - Code block

3 participants