fix(menu): respect prefers reduced motion for drilldown - #7553
Merged
mcoker merged 1 commit intoJun 3, 2025
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7553.surge.sh A11y report: https://patternfly-pr-7553-a11y.surge.sh |
sg00dwin
approved these changes
May 29, 2025
Member
Author
|
@andrew-ronaldson 2025-05-29_14-59-57.mp4 |
Member
Author
|
With full motion: 2025-05-29_15-01-15.mp4 |
Collaborator
|
🎉 This PR is included in version 6.3.0-prerelease.25 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6739
Adds support for the prefers-reduced-motion media query to the Menu component drilldown menu.
Changes:
Set default transition duration to 0s for all transitions
Apply standard transition durations only for users who don't prefer reduced motion
Instead of removing transitions, I had to set the durations to 0s; otherwise the menu did not behave properly.
Setting the overall menu transition duration was necessary or else the nested menus would still have a transition duration and show the translate happening.
That said, the 0s duration does not seem to affect the fade in of other menus - that seems like it might still be coming from Popper despite the !important declaration.
@andrew-ronaldson I left the transition on the height - do you think it should be removed as well?