Skip to content

fix(expandable-section): transition display instead of hidden attr - #7511

Merged
mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-7510
May 7, 2025
Merged

mcoker merged 1 commit into
patternfly:mainfrom
mcoker:issue-7510

Conversation

@mcoker

@mcoker mcoker commented May 7, 2025 •

Copy link
Copy Markdown
Contributor

fixes #7510
fixes #7507

Allows hidden to still be applied (to avoid a breaking change) but the content is now shown/hidden by toggling display: none.

@patternfly-build

patternfly-build commented May 7, 2025 •

Copy link
Copy Markdown
Collaborator

@srambach srambach left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thatblindgeye thatblindgeye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good when linked with React locally 😍 If detached expandable sections are fine to have the animation always be "slide in from the top down" then 🚢

@mcoker

mcoker commented May 7, 2025

Copy link
Copy Markdown
Contributor Author

@thatblindgeye opened this issue for detached - do you remember if we landed on a solution for that? #7515

@mcoker
mcoker merged commit a379e71 into patternfly:main May 7, 2025
@mcoker
mcoker deleted the issue-7510 branch May 7, 2025 21:51
@patternfly-build

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 6.3.0-prerelease.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expandable section - toggle display instead of hidden Bug - Expandable section - exclude truncate variant from animation

4 participants